feat(ui5-dynamic-page): ensure visibility of content outside overflow #7845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kineticjs
force-pushed
the
dp-title-toolbar-content
branch
from
57d6ac7
to
6b0c4f2
Compare
| @@ -11,16 +11,19 @@ | |||
| {{/if}} | |||
| </div> | |||
|
|
|||
| <div class="{{classes.wrapper}}"> | |||
| <div class="{{classes.wrapper}}" | |||
| @ui5-_minContentWidthChange={{onMinContentWidthChange}}> | |||
There was a problem hiding this comment.
Minor: the name of the events seems to be defined in kebab-case, all over the project. Could we change this one also?
Co-authored-by: Dobrin Dimchev <[email protected]>
kineticjs
force-pushed
the
dp-title-toolbar-content
branch
from
b69eca3
to
d58eb59
Compare
dobrinyonkov
approved these changes
Nov 21, 2023
|
thanks |
dobrinyonkov
added a commit
to dobrinyonkov/ui5-webcomponents
that referenced
this pull request
Feb 5, 2024
* test: do not merge * feat(ui5-dynamic-page): poc * feat(ui5-dynamic-page): snap on scroll pin expand collapse * feat(ui5-dynamic-page): add floating footer styling and animation (SAP#7857) * feat(ui5-dynamic-page): snap on scroll pin expand collapse * feat(ui5-dynamic-page): add breadcrumbs responsiveness (SAP#7844) * feat(ui5-dynamic-page): ensure visibility of content outside overflow (SAP#7845) * feat(ui5-dynamic-page): ensure visibility of title content that never overflows * feat(ui5-dynamic-page) actions style corrected Co-authored-by: Dobrin Dimchev <[email protected]> * feat(ui5-dynamic-page): sizing of toolbar wrappers corrected * feat(ui5-dynamic-page): apply review feedback --------- Co-authored-by: Dobrin Dimchev <[email protected]> * feat(ui5-dynamic-page): footer no longer takes space when hidden (SAP#7904) * feat(ui5-dynamic-page): prevent unnecessary content overflow when footer hidden * feat(ui5-dynamic-page): move scroll listener to the new scroll container * feat(ui5-dynamic-page): add header padding (SAP#7921) * feat(ui5-dynamic-page): add responsive paddings (SAP#7923) * build: align with new build process * feat(ui5-dynamic-page): fit content that has 100% height (SAP#7928) * feat(ui5-dynamic-page): fit content that has 100% height * feat(ui5-dynamic-page): correct import * feat(ui5-dynamic-page): add tests * feat(ui5-dynamic-page): keyboard handling (SAP#7990) * feat(ui5-dynamic-page): keyboard handling * feat(ui5-dynamic-page): add focus span * fix: add expand and focus on title click --------- Co-authored-by: Dobrin Dimchev <[email protected]> * fix(ui5-dynamic-page): theme styling (SAP#7966) fix(ui5-dynamic-page): apply theme styles Co-authored-by: PetyaMarkovaBogdanova <[email protected]> * feat(ui5-dynamic-page): screen reader support (SAP#7997) * feat(ui5-dynamic-page): screen reader support * feat(ui5-dynamic-page): add tests * feat(ui5-dynamic-page): add general interaction tests (SAP#8056) * docs(ui5-dynamic-page): story and docs added (SAP#8031) fix(ui5-dynamic-page): story and docs added Co-authored-by: PetyaMarkovaBogdanova <[email protected]> * feat(ui5-dynamic-page): add general API tests (SAP#8115) * feat(ui5-dynamic-page): proper docs added (SAP#8130) Co-authored-by: PetyaMarkovaBogdanova <[email protected]> * chore: align docs to new build scripts * chore: use framework's debounce method --------- Co-authored-by: PetyaMarkovaBogdanova <[email protected]> Co-authored-by: Diana Pazheva <[email protected]> Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the toolbar content with "NeverOverflow" is prioritized when distributing the available horizontal space in the ui5-dynamic-page-title